Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendnotification does not show app name on windows and never show icon you set #1940

Closed
lMaxMadl opened this issue Feb 10, 2021 · 11 comments · Fixed by #2813
Closed

sendnotification does not show app name on windows and never show icon you set #1940

lMaxMadl opened this issue Feb 10, 2021 · 11 comments · Fixed by #2813
Labels
enhancement New feature or request

Comments

@lMaxMadl
Copy link

hey
for notification whatever i do name of app don't change like changing app name or set it on compile and ....
but it show app name appID still on windows

@Jacalz
Copy link
Member

Jacalz commented Feb 11, 2021

Hi. Thanks for opening an issue. We prefer if people use the bug report / feature request issue templates to make the issues more clear and understandable for us. Can you please explain more in depth at what issue you are seeing and what you would expect to see?

@lMaxMadl
Copy link
Author

lMaxMadl commented Feb 12, 2021

if people use the bug report / feature request issue templates to make the issues more clear and understandable for us. Can you please explain more in depth at what issue you are seeing and what you would expect to see?

hey ok i really say it too ez for next questions too

for sending an notification must use
app.SendNotification(&fyne.Notification{Title: "Title", Content: "Content"})
it really have some rude problems it show name of app that sends notifications appID on windows always
and
also never show icon of app if set it before too (i tested on android and windows)
it's not nice tbh

Device :
OS: Windows 10 target:Windows-android
Go version: 1.15.7
Fyne version: 2.0.0

@lMaxMadl lMaxMadl changed the title sendnotification don't show appid as name of project sendnotification show appid for name on windows and never show icon you set Feb 12, 2021
@andydotxyz
Copy link
Member

Can you please share a screenshot of the notification and point out where the app id is displayed on Windows?
The notification should be just title and content text.

For android maybe this is a duplicate of #936.
On Windows this could be a feature request for "Show app icon in notification"?

@andydotxyz andydotxyz added the question A question has been asked label Feb 12, 2021
@MatheusAlvesA
Copy link

I'm having the same problem.

Here is my code:

package main

import (
	"time"
	"fyne.io/fyne/v2"
	"fyne.io/fyne/v2/app"
)

func main() {
	a := app.NewWithID("com.example.app")
	w := a.NewWindow("Test App")
	go showNotification(a)
	w.ShowAndRun()
}

func showNotification(a fyne.App) {
	time.Sleep(time.Second * 2)
	a.SendNotification(fyne.NewNotification("Example Title", "Example Content"))
}

And here is the result:
image

The expected result should be:
image

@stuartmscott
Copy link
Member

app/app_windows.go#35

[Windows.UI.Notifications.ToastNotificationManager]::CreateToastNotifier("appID").Show($toast);`

@andydotxyz andydotxyz added enhancement New feature or request and removed question A question has been asked labels Feb 15, 2021
@andydotxyz andydotxyz added this to the Aberlour (next release) milestone Feb 15, 2021
@andydotxyz
Copy link
Member

I have fixed the "appID" static text bug for 2.0.1 but I think we need a new App.SetName(string) for Aberlour to fix this correctly.

@Jacalz
Copy link
Member

Jacalz commented Feb 15, 2021

Can’t we just have it take the name of the first window instead? That should give us a better name than the appID, I think 🤔

@andydotxyz
Copy link
Member

That crosses my mind, but it could also be irrelevant or empty (especially if a splash screen or tool window for example. Maybe that is a better fallback if no Id is set?

@Jacalz
Copy link
Member

Jacalz commented Feb 16, 2021

Well, I think the name of the first window would be better. From what I can see, most people use that as their application name and I would much prefer to have it say wormhole-gui than com.github.jacalz.wormhole-gui. If there is no name for it, we can either fall back to appID or just display “Fyne App”.

@andydotxyz
Copy link
Member

I'm not sure this should have been closed @madaxemad can you say why you thought it was done?

@lMaxMadl lMaxMadl reopened this Feb 22, 2021
@lMaxMadl lMaxMadl changed the title sendnotification show appid for name on windows and never show icon you set sendnotification show appID for name on windows and never show icon you set Feb 24, 2021
@andydotxyz andydotxyz changed the title sendnotification show appID for name on windows and never show icon you set sendnotification does not show app name on windows and never show icon you set Sep 12, 2021
andydotxyz added a commit to andydotxyz/fyne that referenced this issue Feb 28, 2022
@andydotxyz andydotxyz mentioned this issue Feb 28, 2022
4 tasks
@andydotxyz
Copy link
Member

The name is fixed, the icon is also reported in #2592, closing this ticket and leaving the icon specific one open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants