Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom theme does not refresh when variant changes #2006

Closed
andydotxyz opened this issue Feb 22, 2021 · 1 comment
Closed

Custom theme does not refresh when variant changes #2006

andydotxyz opened this issue Feb 22, 2021 · 1 comment
Labels
bug Something isn't working
Milestone
2.0.x - bugfixes ...

Comments

@andydotxyz
Copy link
Member

Describe the bug:

A custom theme loaded that supports light and dark modes not seem to switch correctly at runtime when settings change.

To Reproduce:

Steps to reproduce the behaviour:

  1. Run an app with custom theme that supports variant (like github.com/andydotxyz/notes)
  2. see current theme (light or dark)
  3. load fyne_settings and change theme variant
  4. Notice that the app does not update

Device (please complete the following information):

  • OS: macOS
  • Version: Catalina
  • Go version: 1.15
  • Fyne version: develop
@andydotxyz andydotxyz added the bug Something isn't working label Feb 22, 2021
@fpabl0 fpabl0 mentioned this issue Mar 1, 2021
Merged
3 tasks
andydotxyz pushed a commit that referenced this issue Mar 1, 2021
@fpabl0
Allow custom themes to react theme variant changes, fixes #2006 (#2049)
93b3e48
andydotxyz pushed a commit that referenced this issue Mar 1, 2021
@fpabl0 @andydotxyz
Allow custom themes to react theme variant changes, fixes #2006 (#2049)
ded6eba
@andydotxyz
Copy link
Member Author

This is now on develop and tagged for future release as v2.0.1-rc1

This was referenced Mar 12, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.x - bugfixes since binding, stora...
1 participant
@andydotxyz