Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where long or tall images could jump on load #1430

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Fix issue where long or tall images could jump on load #1430

merged 1 commit into from
Oct 20, 2020

Conversation

andydotxyz
Copy link
Member

Issue was that we were reading aspect before setting it on the first frame.
Fixes #1266

Checklist:

  • Tests included. <- this was a rendering glitch, you can load the reproduction code to test, but it's not seen in test code
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Fix issue where long or tall images could jump on load
d2ef3d4 
Issue was that we were reading aspect before setting it on the first frame.
Fixes fyne-io#1266
@andydotxyz andydotxyz merged commit 4efa211 into fyne-io:develop Oct 20, 2020
@andydotxyz andydotxyz deleted the fix/1266 branch October 20, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmscott stuartmscott stuartmscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andydotxyz @stuartmscott