Use file ops for file:// and document ops for content:// #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
requested changes
Nov 2, 2020
internal/driver/gomobile/android.c
Outdated
|
|
||
| char *str = getString(jni_env, ctx, type); | ||
| return strcmp(str, "vnd.android.document/directory") == 0; | ||
| } |
There was a problem hiding this comment.
I think we should log here that the URI scheme was not known - there will be no other errors logged to help figure such a corner case out.
There was a problem hiding this comment.
Yup good idea, should this be log_fatal, or just log_info?
andydotxyz
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enables apps to access app-specific directories using the file:// scheme, whilst still allowing apps to access other directories using the Document API.
Checklist: