Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup of widget code #3824

Merged
merged 2 commits into from
Apr 16, 2023
Merged

Minor cleanup of widget code #3824

merged 2 commits into from
Apr 16, 2023

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Apr 15, 2023

Description:

Removes a few places where the NewXyz functions to create widgets were re-setting the default values for DisableableWidget and BaseWidget. It also tidies the CreateRenderer() method of widget.List per discussion in fyne-io/fyne-x#56.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

Coverage: 62.025% (-0.006%) from 62.031% when pulling f457a82 on Jacalz:widget-cleanup into c23851b on fyne-io:develop.

@Jacalz Jacalz merged commit 1b2ca3c into fyne-io:develop Apr 16, 2023
@Jacalz Jacalz deleted the widget-cleanup branch April 16, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bluebugs Bluebugs Bluebugs approved these changes

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jacalz @coveralls @andydotxyz @Bluebugs