Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fsnotify to v1.6.0 #3871

Merged
merged 2 commits into from
May 6, 2023
Merged

Update fsnotify to v1.6.0 #3871

merged 2 commits into from
May 6, 2023

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented May 6, 2023

Description:

Update fsnotify to v1.6.0 for improved cpu and memory usage as well as some fancy new syntax that is a lot more readable.

I tested this locally by using fyne_settings, fyne_demo while also removing the settings file.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Jacalz Jacalz changed the title Fsnotify update Update fsnotify to v1.6.0 May 6, 2023
@coveralls
Copy link

Coverage Status

Coverage: 61.982% (+0.03%) from 61.957% when pulling 14dd6d0 on Jacalz:fsnotify-update into b1d74e2 on fyne-io:develop.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS as well, working well

@Jacalz Jacalz merged commit 1842540 into fyne-io:develop May 6, 2023
@Jacalz Jacalz deleted the fsnotify-update branch May 6, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants