Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the golang.org/x/* deps (except for mobile) #3872

Merged
merged 5 commits into from
May 9, 2023

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented May 6, 2023

Description:

Now that Go 1.17 is the lowest supported version, we can finally update the golang.org/x/* packages for various improvements and cleanups. The only one not updated was golang.org/x/mobile because I don't have any mobile device to test on and don't feel comfortable doing that update.

I have tested cmd/fyne and cmd/fyne_demo with these changes. Every update is in a separate commit and everything seems to be working as expected.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Updated the vendor folder (using go mod vendor).

@coveralls
Copy link

coveralls commented May 6, 2023

Coverage Status

Coverage: 62.044%. Remained the same when pulling de29b05 on Jacalz:update-golang-x-deps into ec0d80e on fyne-io:develop.

@andydotxyz
Copy link
Member

We probably need to figure out here the x/mobile is coming from as we have our internal fork so if both are compiled in we are wasting space.

Just formating changes. Nothing major.
@Jacalz
Copy link
Member Author

Jacalz commented May 7, 2023

We only seem to be using the golang.org/x/mobile/exp/f32 package within some goxjs file. Nothing else exists in the vendor folder. I went ahead and updating it as it was mostly just cleanups and formatting changes (https://github.com/golang/mobile/commits/master/exp/f32).

@Jacalz
Copy link
Member Author

Jacalz commented May 7, 2023

It is also worth noting that I don't think we have that package locally within the repository.

@Jacalz Jacalz merged commit 01205ce into fyne-io:develop May 9, 2023
@Jacalz Jacalz deleted the update-golang-x-deps branch May 9, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants