Specify custom desktop file fields in FyneApp.toml #3958
Conversation
Jacalz
changed the title
cmd/fyne_demo/FyneApp.toml
Outdated
|
|
||
| [LinuxAndBSD] | ||
| GenericName = "Fyne Demo" | ||
| Categories = "Development;" |
There was a problem hiding this comment.
Is the trailing ";" optional? It doesn't seem natural to have it here.
Also should we use a more common list separator for Go developers and convert it where required for the output?
?Perhaps even making it a toml list instead of string?
There was a problem hiding this comment.
I don't know if it technically is required but the official documentation uses it.
https://freedesktop.org/wiki/Howto_desktop_files/
There was a problem hiding this comment.
A TOML list sounds like a great idea :)
There was a problem hiding this comment.
I don't know if it technically is required but the official documentation uses it.
By using FDo formatting you still require folk to understand the spec - which we should avoid if possible just like how naming avoids it.
There was a problem hiding this comment.
Indeed but I've switched to TOML lists now so it should no longer be an issue.
|
|
||
| [Development] | ||
| HelperText = "This binary was build with debug symbol" | ||
|
|
||
| [Release] | ||
| HelperText = "This binary was build without debug symbol" | ||
|
|
||
| [LinuxAndBSD] |
There was a problem hiding this comment.
If we make it "Linux,BSD" or "Linux&BSD" it will be machine parsable if we decide to match go's approach to this logic :).
There was a problem hiding this comment.
I tried that but it does not seem to be supported. I tried +, ,, and & before opening this PR but neither seem to be supported.
| Comment = "A demo of Fyne and its capabilities." | ||
| Keywords = "demo;fyne;" | ||
| Keywords = ["demo", "fyne"] |
cmd/fyne_demo/FyneApp.toml
Outdated
| HelperText = "This binary was built without debug symbols" | ||
|
|
||
| [LinuxAndBSD] | ||
| GenericName = "Fyne Demo" |
There was a problem hiding this comment.
What is generic name, and how often should it differ from the Name specified in the details section above?
There was a problem hiding this comment.
For Rymdport, I have "File Transfer" as GenericName. Just like Firefox has "Web Browser". I hope that helps.
There was a problem hiding this comment.
Ah yea thanks. I guess maybe it should be "demo app" or "developer tools" so it's clearer why they are different in this example?
There was a problem hiding this comment.
That's a good point. I'll get that fixed
There was a problem hiding this comment.
Perhaps "Toolkit Demo" even?
|
Thanks. This is going to make the release binaries in Geoffrey so much nicer for Rymdport's users :) |
Description:
This PR adds support for specifying custom metadata fields for Linux and BSD. It is currently hooked up to provide support for adding
GenericName,Categories,Comment, andKeywordsto the desktop files. These fields are the ones that I had to specify manually in io.github.jacalz.rymdport.desktop for Flatpak packaging to be accepted.Checklist: