Insane boost in TextGrid performance for intense usage of the widget #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could be calling this 100s or 1000s of times if the entire text grid was refreshed (up to twice for each cell, possibly faster than refresh rate because this in the event thread not draw). Result is huge boost (see fyneterm usage for example)
|
Did you forget to push the tests? The checkbox is checked but I don't see any in the diff. |
|
Apologies it was a mistake, I wasn't able to figure out how to demonstrate the improvement outside fyneterm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was difficult to write a benchmark as you're balancing the CPU and GPU usage which was lowering the apparent frame rate.
However loading this change into FyneTerm and listing a huge directory used to take around a second, but now it is so fast as to compare with native terminals!!!
I think this does all we can for the referenced issue, to some extend the newline parse on
SetTextcannot be avoided, but FyneTerm does show how to be a little lower level for greater speed.Fixes #3994 and #3142
Checklist: