-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Android and iOS support #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is complete rendering but not a fully functional driver. ***Work in Progress***
Perhaps we need an alternative to fsnotify?
And tidy up un-needed code at the same time
This also means we no longer draw at 60FPS if we don't need to :) Various refactorings here to share common code - more to come. Also fix scale handling - need to add proper DPI detection later
…Android We can hook into the "dark mode" settings that are arriving later this year. Apps can still override this setting.
… window on mobile We cannot navigate back yet...
This fixes crashes but does not provide a keyboard to type with...
…top simulator behaves differently...
Use fyne-io fork of golang.org/x/mobile that pulls the fixes from KorokEngine/mobile over the latest golang.org/x/mobile
It's not complete but it's largely functional
toaster
reviewed
Sep 5, 2019
@@ -11,6 +12,7 @@ import ( | |||
"golang.org/x/mobile/gl" | |||
|
|||
"fyne.io/fyne" | |||
util "fyne.io/fyne/internal/driver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the driver package renamed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was because the local type is "driver" - but that can be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the iOS and Android platforms (using gomobile build at the moment).
Introduced a new Device API for communicating aspects of the hardware available.
Significantly progresses #65 :)