Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly align mobile menu content #4240

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Correctly align mobile menu content #4240

merged 2 commits into from
Sep 13, 2023

Conversation

andydotxyz
Copy link
Member

Fix it so the mobile menu button aligns with the inside of the canvas, not the window edge

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 65.3% (+0.02%) from 65.277% when pulling 92f62dc on andydotxyz:fix/alignmobilemenu into f4504a1 on fyne-io:develop.

Jacalz
Jacalz approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@andydotxyz andydotxyz merged commit 307f928 into fyne-io:develop Sep 13, 2023
11 checks passed
@andydotxyz andydotxyz deleted the fix/alignmobilemenu branch September 13, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz