Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SizeName property to Hyperlink widget #4832

Merged
merged 3 commits into from
May 23, 2024
Merged

Add SizeName property to Hyperlink widget #4832

merged 3 commits into from
May 23, 2024

Conversation

dweymouth
Copy link
Contributor

Description:

Allows for controlling the size of the text of a hyperlink using the theming system.

Fixes #4829

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.

@coveralls
Copy link

coveralls commented May 8, 2024 •
edited
Loading

Coverage Status

coverage: 65.327% (+0.3%) from 65.043%
when pulling f2e6c04 on dweymouth:hyperlink-sizename
into 9810934 on fyne-io:develop.

@dweymouth dweymouth requested a review from andydotxyz May 9, 2024 14:24
@dweymouth dweymouth added this to the "Elgin" release, early 2024 milestone May 11, 2024
Jacalz
Jacalz reviewed May 18, 2024
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'd like to see Andrew give the final review (given that the feature proposal hasn't seen any activity yet) 👍

@dweymouth dweymouth requested review from andydotxyz and removed request for andydotxyz May 21, 2024 14:28
andydotxyz
andydotxyz previously approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why this would be needed, thanks

@dweymouth dweymouth merged commit 80f9710 into fyne-io:develop May 23, 2024
12 checks passed
@dweymouth dweymouth deleted the hyperlink-sizename branch May 23, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

@Jacalz Jacalz Awaiting requested review from Jacalz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
"Elgin" release, early 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@dweymouth @coveralls @andydotxyz @Jacalz