fix mobile mobile driver absolute position computation for padded child windows #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the handling of the window-head offset.
…mobileCanvas#sizeContent This simplifies the next diff where the offset computation is extracted. This changes the local decision for the full-width window-head from “chrome box contains more than one element” to “chrome box displaces content”. This is still not a total straight forward decision but not worse then the old one which will survive in the extracted offset computation.
This is also used as height for a displacing chrome box to save another `MinSize()` call.
… child windows This led to misplaced pop-ups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a bug where the absolute position of an element is computed wrong by the mobile driver for child windows. The chrome box is not taken into account when the window is padded and therefore the position is not adjusted accordingly.
This affects the position of drop-downs.
Checklist: