Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroller fix: don't respond to mouse scroll if direction is ScrollNone #4870

Merged
merged 2 commits into from
May 23, 2024
Merged

Scroller fix: don't respond to mouse scroll if direction is ScrollNone #4870

merged 2 commits into from
May 23, 2024

Conversation

dweymouth
Copy link
Contributor

Description:

Fixes #(issue)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented May 23, 2024 •
edited
Loading

Coverage Status

coverage: 65.038% (-0.005%) from 65.043%
when pulling 7e8b516 on dweymouth:scroller-none-fix
into 9810934 on fyne-io:develop.

andydotxyz
andydotxyz reviewed May 23, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

@dweymouth dweymouth merged commit 32e868e into fyne-io:develop May 23, 2024
12 checks passed
@dweymouth dweymouth deleted the scroller-none-fix branch May 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dweymouth @coveralls @andydotxyz @Jacalz