Use the right cache scope for overridden font resources #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me resources Unless overridden by FontSource of course. Fixes fyne-io#4937
toaster
reviewed
Jun 17, 2024
Comment on lines
+114
to
+117
| scope := "" | ||
| if o != nil { // for overridden themes get the cache key right | ||
| scope = cache.WidgetScopeID(o) | ||
| } |
There was a problem hiding this comment.
FYI: Moving the nil check into WidgetScopeID would simplify the callers.
toaster
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4937
Checklist: