Switch to NRGBA in all areas except the openGL painter #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-multiplied. This changed some of the test images, I guess that the alpha channel differences affected their represntation. Also update the image comparison to check the bytes as the RGBA vs NRGBA colour models was breaking things but PNG is always NRGBA, so something strange with the decoder there. Fixes fyne-io#909
stuartmscott
reviewed
May 6, 2020
stuartmscott
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GL requires it pre-multiplied, everywhere else expects RGBA like HTML where any channel can be changed independently.
This changed some of the test images, I guess that the alpha channel differences affected their represntation.
Also update the image comparison to check the bytes as the RGBA vs NRGBA colour models was breaking things
but PNG is always NRGBA, so something strange with the decoder there.
This may result in very subtle changes in how shadows are applied but will not impact the API in general. If people pass in a color.RGBA or color.NRGBA it will still be respected.
Fixes #909
Checklist: