Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(webapp): document selection highlight does not work for childs #65

Closed
fynnfluegge opened this issue Jun 14, 2023 · 5 comments · Fixed by #90
Closed

bug(webapp): document selection highlight does not work for childs #65

fynnfluegge opened this issue Jun 14, 2023 · 5 comments · Fixed by #90
Labels
bug Something isn't working effort low good first issue Good for newcomers

Comments

@fynnfluegge
Copy link
Owner

When selecting a child node in the document tree the highlight color does not appear anymore.

@fynnfluegge fynnfluegge added bug Something isn't working good first issue Good for newcomers effort low labels Jun 14, 2023
@vishalpawarR
Copy link

@fynnfluegge Hey can you please provide me the proper steps for reproducing the issue so that I can help you with this quickly? Please also provide screenshot for better understanding.

@fynnfluegge
Copy link
Owner Author

Hey @vishalpawarR thanks for your help! 🙌
You can reproduce the bug by simply selecting a child document in the document tree:
Screenshot 2023-06-14 at 21 59 47

You can see in this screenshot I selected ZSH Setup and afterwards selected the ranger document, which is a child of it.
But the highlighted item in the document tree is still ZSH Setup.
The expected behaviour would be highlighting ranger. You can reproduce it with any child document.

I have the feeling the bug occurred in one of the last commits if this might help you.
If you need more help feel free to ask! 🙂

@fynnfluegge fynnfluegge changed the title bug(webapp) document selection highlight does not work for chillds bug(webapp): document selection highlight does not work for chillds Jun 14, 2023
@fynnfluegge
Copy link
Owner Author

Hey @vishalpawarR I have an idea about this. In #64 I changed the behaviour of the selection of a document with an onchange event by using (click)="openItem(node.id)" instead of calling a routerlink. I forgot to do this for the parent nodes with hasChild property. That should be a quickfix for now, but I think the highlight color does not work anymore because routerLinkActive="active-node" does not work with the onchange event.

@fynnfluegge
Copy link
Owner Author

Pushed a quickfix here 45e68dd because parent selection was broken after selecting a child. Hightlight color after selection still does not work currently.

@fynnfluegge fynnfluegge changed the title bug(webapp): document selection highlight does not work for chillds bug(webapp): document selection highlight does not work for childs Jun 17, 2023
@fynnfluegge
Copy link
Owner Author

@fynnfluegge Hey can you please provide me the proper steps for reproducing the issue so that I can help you with this quickly? Please also provide screenshot for better understanding.

Hey @vishalpawarR how you doing? Feel free to let me know if you need some help or introduction to the project 🙌

fynnfluegge added a commit that referenced this issue Nov 5, 2023
Adds functionality to select and edit documents in the editor component.
When a document is selected, its content is fetched from the server and
displayed in the editor. The commit also includes changes to the sidenav
component to highlight the selected document and update the content in
the editor when a document is selected. Additionally, it adds input
fields for creating and editing document titles.

Fixes #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort low good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants