Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix buffer overflow exceptions #10

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

odisseus
Copy link
Contributor

This pull request contains code from PR #8 by @larsjaas along with some improvements to buffer size calculation and test assertions.

@odisseus
Copy link
Contributor Author

@fzakaria, is there any chance that either this PR or #8 will ever get merged?

@fzakaria
Copy link
Owner

Sorry for the delay.
Looks good & will merge!

@fzakaria fzakaria merged commit fc49725 into fzakaria:master Jul 28, 2020
@fzakaria
Copy link
Owner

@odisseus a comment I had but never submitted on #8 was

why not just do a string replace of z with !!!! and we keep the logic clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants