Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cl-num-utils #4

Closed
Symbolics opened this issue Apr 1, 2023 · 10 comments
Closed

Update cl-num-utils #4

Symbolics opened this issue Apr 1, 2023 · 10 comments

Comments

@Symbolics
Copy link

Hello Frank,

I'm glad to have found this library; I've been looking for some machine learning code in Common Lisp that doesn't have a restrictive license, and found this because I'm the new maintainer of LLA, and when updating it in Quicklisp discovered some breakage.

cl-num-utils has been updated and renamed num-utils, and that's what now LLA uses. Here, when used together, there is a package name clash because LLA and cl-num-utils aren't in sync.

The fix is to change cl-num-utils -> num-utils in the mlep-add ASDF file.

@fzalkow
Copy link
Owner

fzalkow commented Apr 1, 2023

Hi, thanks for raising this issue! I haven't used Lisp for years, so please refresh my background if I miss something.

After updating the Quicklisp client (ql:update-client) to the most recent version 2021-02-13, (ql:quickload :num-utils) throws an error, but (ql:quickload :cl-num-utils) succeeds. This indicates that cl-num-utils is still the right name for the lib. Am I wrong?

@Symbolics
Copy link
Author

It sounds like you need to update the software distributions list in addition to the client. Try (ql:update-dist "quicklisp")

fzalkow added a commit that referenced this issue Apr 2, 2023
@fzalkow
Copy link
Owner

fzalkow commented Apr 2, 2023

Thanks; that did the trick! I replaced cl-num-utils with num-utils (e6a115f). This should resolve this issue, right?

@Symbolics
Copy link
Author

Yes, it should. Does cl-mlep have a test suite we can try?

@fzalkow
Copy link
Owner

fzalkow commented Apr 2, 2023

We have, unfortunately, no test suite, but we can try to replicate the usage examples. When loading load-with-add.lisp, I get the following error:

"XREAL" is already a nickname for "CL-NUM-UTILS.EXTENDED-REAL".

I guess this is due to the lla package, which still depends on cl-num-utils instead of num-utils, which makes our update inconsistent with lla.
https://github.com/tpapp/lla/blob/master/lla.asd#L17

@Symbolics
Copy link
Author

Symbolics commented Apr 2, 2023

Yes, that's exactly correct. I'm in the process of getting the new LLA into Quicklisp. Now that cl-mlep is 'ready', I'll go back and get that process moving. Once Quicklisp's LLA is the new one, then all should work. I'll report back here once that's done.

For reference, that is quicklisp/quicklisp-projects#2276

@fzalkow
Copy link
Owner

fzalkow commented Apr 2, 2023

Great, thanks for your efforts! 👍

@fzalkow
Copy link
Owner

fzalkow commented Aug 1, 2023

@Symbolics, can we close this issue?

@snunez1
Copy link

snunez1 commented Aug 2, 2023

Yes, let's do that. I wasn't able to test, but the new LLA seems to be functionally equivalent.

@fzalkow
Copy link
Owner

fzalkow commented Aug 2, 2023

I verified that the PCA example from the documentation (where LLA is used) is working after updating quicklip, with a minor additional commit I have done now. Thanks!

@fzalkow fzalkow closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants