Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double definition of is_int in c++11 mode (g++) #107

Closed
KillianDS opened this issue Aug 15, 2013 · 1 comment
Closed

double definition of is_int in c++11 mode (g++) #107

KillianDS opened this issue Aug 15, 2013 · 1 comment
Assignees
@Groovounet
Labels
bug
Milestone
GLM 0.9.4

Comments

@KillianDS
Copy link

I got following error with C++11 mode on gcc 4.8 (I used latest version):
third_party/include/glm/core/type_int.hpp:207:10: error: redefinition of 'struct glm::detail::is_int<long int>' struct is_int<T> \ ^ third_party/include/glm/core/type_int.hpp:220:2: note: in expansion of macro 'GLM_DETAIL_IS_INT' GLM_DETAIL_IS_INT(highp_int_t); ^ compilation terminated due to -Wfatal-errors.

I have a fix, but I'm not sure if it's the best possible one as I don't know enough of glm's internal typing system. https://github.com/KillianDS/glm/commit/173928ca8a8622798f557f334c9b606e0be22590 (That branch also includes a fix for an issue I had with clang).
Groovounet added a commit that referenced this issue Aug 18, 2013
@Groovounet
Fixed is_int and is_uint code duplication with GCC and C++11 #107
1ab7271
@ghost ghost assigned Groovounet Aug 18, 2013
@Groovounet
Copy link
Member

This bug should be fixed in GLM 0.9.4 branch.

Thanks for contributing,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
bug
Projects
None yet
Milestone
GLM 0.9.4
Development

No branches or pull requests
2 participants
@Groovounet @KillianDS