Disable Cloudflare proxying on link.mchc.g0v.ca #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OctoDNS Plan for
|
||||||||||||||||||||||||
| Operation | Name | Type | TTL | Value | Source |
|---|---|---|---|---|---|
| Update | link | A | 1 | 52.72.49.79 | |
| 120 | 52.72.49.79 | config-files | |||
| Summary: Creates=0, Updates=1, Deletes=0, Existing Records=7 | |||||
|
Ah shoot. The above message is not what I'd expect. It's clashing with #34 (which has now been merged), but this branch was created before that PR was. It seems that the test workflow is being run against the feature branch rather than against the merge commit of feature+mainline. So this will make the test workflow give wonky update comments when more than one PR is active... Will-reticket. |
patcon
force-pushed
the
remove-mchc-shortlink-proxy
branch
from
ae94f6e
to
34a5862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With proxying, https:// shortlinks fail. The allows them to work again.
(This is only required for beyond third-level domains: e.g., for
link.sub.domain.com, but notlink.domain.com.)Won't merge this until I've created some other PRs, and I created some DNS records directly in cloudflare during testing, and merging will immediately wipe them out during sync.)
To Do