Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numbering legistator #21

Merged
merged 3 commits into from
May 26, 2019
Merged

numbering legistator #21

merged 3 commits into from
May 26, 2019

Conversation

howlongru
Copy link
Collaborator

Numbering legislator.

Result format: CSV.

@howlongru howlongru self-assigned this May 26, 2019
@howlongru howlongru mentioned this pull request May 26, 2019
Closed
bangyuwen
bangyuwen reviewed May 26, 2019
View reviewed changes
Copy link
Collaborator

@bangyuwen bangyuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source會怎麼產生呢？直接用 data/history_legislator_info_page*.json 來做mapping嗎？

preprocessing/numbering/README.md Outdated Show resolved Hide resolved
preprocessing/numbering/numbering_legislator.py Show resolved Hide resolved
@howlongru
Copy link
Collaborator Author

source會怎麼產生呢？直接用 data/history_legislator_info_page*.json 來做mapping嗎？

如果只要這屆的只能等中選會的公布資料放到source

@bangyuwen
Copy link
Collaborator

我記得我們那時候討論的時候說要把歷屆立委都編ID上去？

@howlongru
Copy link
Collaborator Author

我記得我們那時候討論的時候說要把歷屆立委都編ID上去？

最後決定只有做這屆吧 所以只有本屆參選人會有整理過的資料

@bangyuwen
Copy link
Collaborator

我記得我們那時候討論的時候說要把歷屆立委都編ID上去？

最後決定只有做這屆吧 所以只有本屆參選人會有整理過的資料

這我沒有意見，我再把目前有的參選名單爬給你
目前初步名單在這裡：https://zh.wikipedia.org/wiki/2020%E5%B9%B4%E4%B8%AD%E8%8F%AF%E6%B0%91%E5%9C%8B%E7%AB%8B%E6%B3%95%E5%A7%94%E5%93%A1%E9%81%B8%E8%88%89#%E5%8D%80%E5%9F%9F%E6%9A%A8%E5%8E%9F%E4%BD%8F%E6%B0%91%E9%81%B8%E8%88%89_2

@bangyuwen
Copy link
Collaborator

ok

@howlongru howlongru merged commit a19681c into master May 26, 2019
@bangyuwen bangyuwen deleted the numbering branch May 26, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangyuwen bangyuwen bangyuwen approved these changes

@kbearXD kbearXD Awaiting requested review from kbearXD

@littledollcat littledollcat Awaiting requested review from littledollcat

@terenzio terenzio Awaiting requested review from terenzio

Assignees

@howlongru howlongru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howlongru @bangyuwen