add application version number information #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppavlovic
requested changes
Jun 29, 2023
src/Data/LoggerAbstract.php
Outdated
| @@ -103,6 +107,17 @@ public function setExcluded(Exclude $exclude) | |||
| $this->exclude = $exclude; | |||
| } | |||
|
|
|||
| public function setAppVersionNumber($version) | |||
There was a problem hiding this comment.
Add type hint:
public function setAppVersionNumber(Version $version)
src/Data/LoggerAbstract.php
Outdated
|
|
||
| public function getAppVersionNumber() | ||
| { | ||
| return $this->version instanceof Version ? $this->version->getVersionNumber() : $this->version; |
There was a problem hiding this comment.
Did you mean to write something like:
return $this->version instanceof Version ? $this->version->getVersionNumber() : null
There was a problem hiding this comment.
No. $this->version can be null by itself so no need to do ": null". I'm just making the check to make sure the ->getVersionNumber method doesn't break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.