Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git remote add upstream could be confused with push --set-upstream in Remotes section #12

Open
BenGitsCode opened this issue Jan 8, 2017 · 4 comments

Comments

@BenGitsCode
Copy link
Contributor

BenGitsCode commented Jan 8, 2017

I'm curious as why our instructions have them adding the remote singularly and not setting the upstream on a push.

Is there a pedagogical purpose to doing this (i.e. here's remotes in a nutshell and how to associate your local branch with a remote branch) but githubs instructions for connecting new local repos to remotes / creating repos always suggest the "set upstream on initial commit convention—and the developers will see that a lot.

I can see pedagogical value in starting with just adding remotes, and building up to what remotes and upstreams are, but it just struck me as unexpected.

I guess what I'm asking is would it grok easier with the developers if we called that fork or my-fork or something, to show that the remote name is just a variable we can change and that upstream is a convention.

This ties into #10 but I'm not clear on the consensus.

@jrhorn424
Copy link

@BenGitsCode What are your thoughts about teaching remotes only when they're needed?

@BenGitsCode
Copy link
Contributor Author

@jrhorn424 I'm torn. I prefer the idea of trickling git details in only as they need them—but remote mismatches due to not forking often plays that hand for us sooner, as we detangle the problem for them.

If we took that approach, we would need to be miltant about walking them through forking and cloning. If we could do that, and omit remotes for now, I think it's less for them to take in at once (which is good with git) but we would need to be more general in our explanation of local and remote repos. Explaining that without remotes strikes me as tricky.

I like the idea, I'm not sure how to implement it.

Do you mean remove the remotes section and only teach it as it comes up instead?

@gaand
Copy link

gaand commented Jan 10, 2017

Setting a remotes url is part of the fix to the clone not fork. It's probably good if they've seen it.

@MicFin
Copy link
Contributor

MicFin commented Mar 19, 2017

Could close and reference from Issue #10

@MicFin MicFin removed the question label Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants