Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Should GA4GHRead.alignedBases be included? #3

Closed
cassiedoll opened this issue Apr 2, 2014 · 4 comments
Closed

Should GA4GHRead.alignedBases be included? #3

cassiedoll opened this issue Apr 2, 2014 · 4 comments

Comments

@cassiedoll
Copy link
Member

The original goal of GA4GHRead.alignedBases was to reduce the need for users to parse the cigar field. When using the current implementation of Google's API, I haven't found this to be particularly useful.

We might consider an alternative representation of the cigar that requires less regex usage while still being compact.

(maybe a more formal structure, like [{type: deletion, count: 10}, {type: match, count: 30}]? or anything else that might help with parsing and be easy for api providers to support)

@delagoya
Copy link
Contributor

delagoya commented Apr 2, 2014

I agree that it will not be of much use if we "fix" CIGAR represenations. We should put a separate issue for that though, and not mix in these two commits.

@dglazer
Copy link
Member

dglazer commented Apr 26, 2014

Addressed by @fnothaft in #30 -- we can discuss details there. Closing.

@dglazer dglazer closed this as completed Apr 26, 2014
@dglazer
Copy link
Member

dglazer commented Apr 27, 2014

Re-opening, since #30 was closed.

@dglazer
Copy link
Member

dglazer commented May 1, 2014

Closing (addressed in #33)

@dglazer dglazer closed this as completed May 1, 2014
macieksmuga pushed a commit that referenced this issue Jun 7, 2016
Removed unnecessary imports that were causing tests to fail.
dcolligan pushed a commit to dcolligan/ga4gh-schemas that referenced this issue Jul 20, 2016
Add basic variant and callset searching
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants