This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
First step to fileData cleanup #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cassiedoll
commented
Apr 18, 2014
cassiedoll
commented
- part of issue We should clean up GA4GHReadSet.fileData #2
- inline the headerSections field, the indirection isn't necessary, all sub-fields are already repeated
- remove the header object, because neither sorting_order nor bam version is applicable in this format
- remove fileUri for the same reason
- inline the headerSections field - remove the header object, because neither sorting_order nor bam version is applicable in this format - remove fileUri for the same reason
|
+1 -- nice step towards cleaning up the semantics to be API-centric, not legacy file-format centric, without losing any information |
|
+1 |
1 similar comment
|
+1 |
Conflicts: src/main/resources/avro/ga4gh.avdl
|
Updated to GA prefix |
dglazer
added a commit
that referenced
this pull request
Apr 29, 2014
First step to fileData cleanup
dcolligan
pushed a commit
to dcolligan/ga4gh-schemas
that referenced
this pull request
Jul 20, 2016
Offer an alternative command line to run the test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.