Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Replace NCBI taxon ID integer with ontology term #699

Merged
merged 4 commits into from
Feb 1, 2017

Conversation

david4096
Copy link
Member

In #612 I mentioned the inconsistency in representing the NCBI taxon ID as an integer on a reference when the biometadata objects use an Ontology term. This PR closes #612 by replacing the NCBI taxon ID int32 with an ontology term.

@mbaudis
Copy link
Member

mbaudis commented Aug 24, 2016

-1 on this in the current implementation.

Species is defined inbio_metadata.Individual.species

So this should be a reference to the individual (or a copy of the same structure, as a fudge; i.e. OntologyTerm species instead of OntologyTerm ncbi_taxon_id).

  // For a representation of an NCBI Taxon ID as an OntologyTerm, see
  // NCBITaxon Ontology
  //   http://www.obofoundry.org/ontology/ncbitaxon.html
  // For example, 'Homo sapiens' has the ID 9606. The NCBITaxon ontology ID for
  // this is NCBITaxon:9606, which has the URI
  // http://purl.obolibrary.org/obo/NCBITaxon_9606
  OntologyTerm species = 7;

@david4096
Copy link
Member Author

Thanks @mbaudis, that makes sense I've changed the field to be named species.

@mbaudis
Copy link
Member

mbaudis commented Aug 25, 2016

+1 (and removal of the -1 above)

@david4096
Copy link
Member Author

Updated to include using an Ontology Term on reference sets as well. Thanks @ejacox !

@david4096
Copy link
Member Author

Implemented in the server here, and client with demonstrated tests in compliance.

@ejacox ejacox merged commit 17cadf4 into ga4gh:master Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

References replace NCBI Taxon ID with Ontology Term
4 participants