This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 110
Replace NCBI taxon ID integer with ontology term #699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-1 on this in the current implementation. Species is defined in So this should be a reference to the individual (or a copy of the same structure, as a fudge; i.e.
|
david4096
force-pushed
the
612_taxon_id
branch
from
August 24, 2016 19:46
c2d1f31
to
77c98b8
Compare
Thanks @mbaudis, that makes sense I've changed the field to be named species. |
+1 (and removal of the -1 above) |
This was referenced Dec 7, 2016
david4096
force-pushed
the
612_taxon_id
branch
from
December 12, 2016 22:26
77c98b8
to
c53e5e2
Compare
Updated to include using an Ontology Term on reference sets as well. Thanks @ejacox ! |
This was referenced Dec 21, 2016
Implemented in the server here, and client with demonstrated tests in compliance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #612 I mentioned the inconsistency in representing the NCBI taxon ID as an integer on a reference when the biometadata objects use an Ontology term. This PR closes #612 by replacing the NCBI taxon ID
int32
with an ontology term.