Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize.py - no right trimming? #1

Closed
ppawliczek opened this issue Jan 8, 2018 · 1 comment
Closed

normalize.py - no right trimming? #1

ppawliczek opened this issue Jan 8, 2018 · 1 comment

Comments

@ppawliczek
Copy link

I think that you need right trimming also at the beginning of normalization.

I would add ((3, 6), "CG") to tests (it should result in ((4,5),""))

https://github.com/ga4gh/vmc-python/blob/f519f61cf2f0f010f9beacff23e931a0d2268417/vmc/normalize.py#L117

@reece reece closed this as completed in b685561 Jan 22, 2018
@reece
Copy link
Member

reece commented Jan 22, 2018

Thanks @ppawliczek! Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants