Add package resource for unzip to init.pp #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds package resource declaration to ensure that the `unzip` package is installed.
|
Can you add a class parameter, something like "manage_unzip" defaulting to false, that wraps this up and only does it if the user opts in? |
* Adds parameter manage_unzip, defaults to false, that toggles whether puppet-ngrok manages a package resource for unzip, a dependency of the archive resource. * Also adds a before statement to the unzip package resource to ensure that, if unzip is managed, the package resource is resolved before the archive resource.
|
@gabe-sky PR has been updated with a parameter to toggle whether |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unzippackageis installed.