Make spdlog_ex::spdlog_ex work with fmt 8.0.0 #1976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbolli
added a commit
to bbolli/MINGW-packages
that referenced
this pull request
Jul 4, 2021
Apply the patch from gabime/spdlog#1976 while spdlog hasn't released a version compatible with fmt 8.0.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fmt 8.0.0 was released two days ago (2021-06-21) and this change is required to use spdlog with the new release. This change is backwards compatible to older versions of fmt. I think the bundled version of fmt should probably be updated too, but I'm not sure the recommended way to do that.