Simplified Qt sinks #2016
Merged
Simplified Qt sinks #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed private class that derived from QObject
Removed private class that derived from QObject
mguludag
commented
Jul 27, 2021
gabime
requested changes
Jul 27, 2021
include/spdlog/sinks/qt_sinks.h
Outdated
| template <typename Mutex> | ||
| class qtextedit_sink : public base_sink<Mutex> { | ||
| public: | ||
| qtextedit_sink(QTextEdit *textedit = nullptr) { |
There was a problem hiding this comment.
why allow nullptr by default if it throws if nullptr?
include/spdlog/sinks/qt_sinks.h
Outdated
| ~qtextedit_sink() { flush_(); } | ||
|
|
||
| protected: | ||
| void sink_it_(const details::log_msg &msg) override { |
include/spdlog/sinks/qt_sinks.h
Outdated
| void flush_() override {} | ||
|
|
||
| private: | ||
| QTextEdit* qtextedit = nullptr; |
There was a problem hiding this comment.
please rename to qtextedit_ like rest of spdlog
mguludag
commented
Jul 27, 2021
|
Thanks. Please fix the conflict so i can merge |
gabime
reviewed
Jul 27, 2021
| base_sink<Mutex>::formatter_->format(msg, formatted); | ||
| string_view_t str = string_view_t(formatted.data(), formatted.size()); | ||
| QMetaObject::invokeMethod(qtextedit_,"append", Qt::AutoConnection, Q_ARG(QString, QString::fromUtf8(str.data(), static_cast<int>(str.size())).trimmed())); | ||
| } |
There was a problem hiding this comment.
why the change from the simple append()? seems inefficient.
There was a problem hiding this comment.
Direct calling GUI widget functions from another threads in Qt app results crash. Qt forces us to use their own Q_OBJECT macro and connect function or QMetaObject::invokemethod function.
|
Thanks @mguludag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @FlorianWolters for this idea. New header is more simpler and no private classes derived from QObject. Its also thread-safe (logging from any thread is safe)