Add memory mapped file based logging #2604
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This solves a sort-of-an-issue where app crashes cause file logs to appear truncated, because the logger isn't flushed. By implementing a sink that uses memory-mapped files, we ensure that the data is still written even on abnormal exit. This allows us to enjoy a highly performant sink with very rare flushing while still getting all of our logs after a crash.
I'm not too familiar with this codebase, could you please assist me in tidying the edges of this sink (making mem_buffer_size configurable,
ifdef
ing the entire thing only to Linux, etc.)?