Dirty fix for Intel compiler compatibility. #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so what is the fix exactly? is it removing the “inlne”? changing the variable name? |
|
It takes away the inline due to how Intel compiler deals with TLS variables, and works around a variable name collision. It is not a very pretty fix - I need to look into exactly what icpc does differently for a better fix. I'm strongly suspecting a corner case bug that will need to be worked around, but might as well be wrong. |
|
ok. i will wait with the merge until you investigate more. |
|
Yeah, this isn't the right patch for this problem. Apologies for the noise. I have a strong hunch this is a compiler bug, but I don't have a good idea to fix this from the back of my head. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel compiler seems to have slightly different behavior when it comes to handling symbols that reference TLS members than what os.h expects. This is by no means a pretty fix, but more of a quick fix to fail compiling entirely when building against the Intel compiler on macOS.