Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless Mode #6

Closed
JakeWharton opened this issue Mar 11, 2014 · 16 comments
Closed

Endless Mode #6

JakeWharton opened this issue Mar 11, 2014 · 16 comments

Comments

@JakeWharton
Copy link

Please add a checkbox for "Endless Mode" where reaching 2048 is just another number and you are allowed to continue playing.

This should probably be differentiated in the pre-populated tweet so as to differentiate it from normal "2048" mode.

@gabrielecirulli
Copy link
Owner

Hey! This seems like a nice idea but probably requires a bit of ground work. As far as I know, @marg51 should be working on this, so I'm going to wait until we hear from him!

@marg51
Copy link
Contributor

marg51 commented Mar 11, 2014

Yeah I have done something quite different.

When you win, you can continue the game by clicking keep playing. Easy implementation. Just one mode. What do you think ?


As regards twitter, I agreed.

  • One tweet when you win: I won [...]
  • One tweet when there is no more move available ( 2048 or not ): I scored [...]

@JakeWharton
Copy link
Author

That sounds perfect. Elegant solution.
On Mar 11, 2014 10:16 AM, "Margirier Laurent" notifications@github.com
wrote:

Yeah I have done something quite different.

https://f.cloud.github.com/assets/543507/2388008/6c8b1662-a93d-11e3-90b3-4100bd413434.png

When you win, you can continue the game by clicking keep playing. Easy

implementation. Just one mode. What do you think ?

As regards twitter, I agreed.

  • One tweet when you win: I won [...]
  • One tweet when there is no more move available ( 2048 or not ): I
    scored [...]

Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-37322595
.

marg51 added a commit to marg51/2048 that referenced this issue Mar 11, 2014
Add a button to keep playing after user has won.
A state `keepPlaying` is added to GameManager, and is true when user clicked on the button "keepPlaying", default to false.

Closes gabrielecirulli#6
@gabrielecirulli
Copy link
Owner

I like that solution as well. Very elegant, and removes the need to have checkboxes and other things laying around. I'd say the only thing left to figure out is what color to use on tiles above 2048 and up to what tile it makes sense to build styles. I think we could go with a special color for tiles above 2048 to make it feel "elite", but we should also run some calculations to figure out what tile is likely to never be seen and end support there. It shouldn't cost much to add styles up to 65536. I doubt anyone will get up to that point, and if they do, they should probably invest some time in getting their life back together 😄

@warmwaffles
Copy link

@gabrielecirulli you could switch over to another color style from that point forward.

@gabrielecirulli
Copy link
Owner

Any ideas over specific colors? I tried to use warm colors for all the tiles, so it might be good to continue on that pattern.

@JakeWharton
Copy link
Author

Maybe just step towards #000000 or #ffffff from the 2048 tile's color.

@gabrielecirulli
Copy link
Owner

That could work.

@JakeWharton
Copy link
Author

Please add an easter egg if you "lose" with tiles: 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16385, 32768, 65536. Even if only by cheating :)

@warmwaffles
Copy link

It would be fun to actually have it roll over to negatives

counting sheep

@marg51
Copy link
Contributor

marg51 commented Mar 12, 2014

There are conflicts with my code and PR 3 (LocalStorage).
I'm waiting for the merge to resolve them and push my code.

@gabrielecirulli
Copy link
Owner

I'm merging #3 at the moment, with some tweaks. Should be up in a bit. You could try merging again after that.

@gabrielecirulli
Copy link
Owner

Master is now up to date

@BrunoSpy
Copy link

Thanks for this nice improvement ! When will it be avalaible on http://gabrielecirulli.github.io/2048/ ?

@gabrielecirulli
Copy link
Owner

Now included in the game

@MiniGod
Copy link

MiniGod commented Mar 16, 2014

Guys... Maybe we should rename the game?
4096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants