Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle VCSs; skip missing ocamlformat; append existing files #1

Open
wants to merge 3 commits into
base: feature/gabyfle/gitignore-fmt-init
Choose a base branch
from

Conversation

toastal
Copy link

@toastal toastal commented Jan 16, 2024

Missing: tests. I do not know how to write these.

Tests that would be nice to have:

  1. .ocamlformat is missing if the binary is missing; there is already a warning, so I don’t think a blank file needs to be echoed… especially since there exists alternative formatters
  2. echo "# Hello, world! > .gitignore", & test that that string is still there since _build/ should be appended.

Appending is required to support Pijul since pijul init creates .ignore with .git & .DS_Store by default.

@toastal
Copy link
Author

toastal commented Mar 27, 2024

bump?

@maxRN
Copy link

maxRN commented Jul 10, 2024

Hey @toastal I think you should open the PR against the actual dune repository or it won't show up and can easily get lost. (Seems like this PR went under the dune maintainers' radar)
If you are no longer interested in this change I would also be more than happy to take this on and see this change through.

@toastal
Copy link
Author

toastal commented Jul 11, 2024 via email

@maxRN
Copy link

maxRN commented Jul 11, 2024

Ah, sorry for the confusion. I was reading ocaml#9567 and didn't notice that you had created a PR against the dune Repo already. I read until the bottom and this is where I found the link to this PR. I see that you commented on the PR again to bump it, hopefully that means it will pick up steam again. Very happy to see this feature being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants