Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nql array node #4

Merged
merged 53 commits into from
Dec 22, 2020
Merged

Nql array node #4

merged 53 commits into from
Dec 22, 2020

Conversation

diegosenarruzza
Copy link
Collaborator

  • Allow use of arrays in nql sentences with square bracket character,
  • Move sttatic nql comparisons to use an dinamyc strategy. It could be changed with a configuration variable.
  • Add support for arrays in nql, according with strategy.

@diegosenarruzza
add syntax to use arrays in nql
238b196
@diegosenarruzza
add nql array strategy as suport of array nodes in nql
ae7735b
@diegosenarruzza
change responsability about how to filter condition in Include condit…
758367a 
…ion with array support
@diegosenarruzza
add tests in filter condition to validate array strategy methods when…
7402b69 
… dont config it
@diegosenarruzza
add and test a simple array strategy for sqlite
21d0aa4
@diegosenarruzza
fix name of array strategies module
fcdf6e0
@diegosenarruzza
fix syntax to convert array as a basic rule
25fa684
@diegosenarruzza
fix comparisons to difference between basic attribute and array attri…
3982c6a 
…bute, each one forward to correspond method of strategy
@diegosenarruzza
add tests in nql filter condition to test all kind of methods to none…
258d45f 
… array strategy
@diegosenarruzza
add and test more methods to sqlite array strategy
4552dcc
@diegosenarruzza
add filter not equal method for sqlite strategy
30e18b4
@diegosenarruzza
add exception for not supported methods in array strategy
3f00570
@diegosenarruzza
refactor none array strategy
1fb22a8
@diegosenarruzza
add sqlite type converters for array
36a632c
@diegosenarruzza
add tests for sqlite type converters
3bea456
@diegosenarruzza
add module to nql filter condition strategies and class comparison to…
4beb839 
… each kind of comparison in nql
@diegosenarruzza
add a none strategy to filter condition strategies
e7c1b62
@diegosenarruzza
refactor sqlite filter condition strategy and add exception to not su…
dbcf71f 
…pporteds methods
@diegosenarruzza
remove and replace nql array strategies to filter condition strategies
d5da57b
@diegosenarruzza
fix specs to test filter condition strategies
a45d37a
@diegosenarruzza
fix array node in nql
1f9f18f
@diegosenarruzza
fix name sqlite strategy, remove scoped name
97cb506
@diegosenarruzza
fix bad definition in syntax
63401d0
@diegosenarruzza
refactor filter condition strategies and submodule comparisons
395e81a
@diegosenarruzza
first approach to filter condition strategies for postgres
8f1f950
@diegosenarruzza
add comparisons for greather and less in filter condition postgres
9bb948a
@diegosenarruzza
fix comparisons for postgres filter condition
6669e79
@diegosenarruzza
add postgres negative comparisons for filter conditions
85bf33a
@diegosenarruzza
add not support for comparison like in postgres array
555c53a
@diegosenarruzza
fix comparisons in postgres filter condition
11c0c1a
Gabriel Naiman and others added 21 commits December 9, 2020 09:14
Remove unused methods
88ab913
Unnecesary method in base class
15f45c0
Refactor sqlite type converter
1c6e6cd
Fixed typo
9e2d56e
Refactor filter_condition in comparison nodes
9d15a49
Deprecate NQL::FilterConditionStrategies::NoneStrategy
e30283f
Refactor contants.type
643f5c7
Return symbols
97053ef
Refactor FilterConditionStrategies
8dc7f08
@diegosenarruzza
add each pages method to get rows in blocks
46010cd
Merge remote-tracking branch 'origin/master' into nql_array_node
fc6f43d
@diegosenarruzza
Revert "add each pages method to get rows in blocks"
ccd9854 
This reverts commit 46010cd.
@diegosenarruzza
Merge branch 'master' of github.com:gabynaiman/rasti-db into nql_arra…
2b04285 
…y_node
@diegosenarruzza
Merge branch 'master' of github.com:gabynaiman/rasti-db into nql_arra…
adb14dc 
…y_node
Merge branch 'master' into nql_array_node
2ed4e78
@diegosenarruzza
Merge branch 'nql_array_node' of github.com:gabynaiman/rasti-db into …
245f95c 
…nql_array_node
@diegosenarruzza
add tests for filter condition strategies
15e2f74
@diegosenarruzza
fix syntax nql array to use brackets
e98a331
@diegosenarruzza
fix nql array, identify with square bracket instead of parenthesis
be5ae4b
@diegosenarruzza
fix array tests
61adcec
@diegosenarruzza
fix syntax of literal string and test array with it
1ffb8b1
@coveralls
Copy link

coveralls commented Dec 21, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 0b093f7 on nql_array_node into 2a1ee8f on master.

@gabynaiman gabynaiman merged commit 68bd4fe into master Dec 22, 2020
@gabynaiman gabynaiman deleted the nql_array_node branch December 22, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegosenarruzza @coveralls @gabynaiman