Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PQueue inside EditGraphQL subscriptions #1062

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

scott-rc
Copy link
Collaborator

This adds a PQueue inside EditGraphQL subscriptions so that we:

  1. Process messages in the order we receive them
  2. Never process messages in parallel

This allows our GraphQL subscription handlers to be async while still ensuring they run in the expected order. This also helps us write tests where we can await the handler of a message rather than watching for external state to change.

None of our current subscriptions need to process messages in parallel, in fact filesync already uses a PQueue internal to prevent this from happening. If we ever need to process messages in parallel in the future, we can add a concurrency option.

Copy link

changeset-bot bot commented Dec 15, 2023

⚠️ No Changeset found

Latest commit: 2736405

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@scott-rc scott-rc enabled auto-merge (squash) December 15, 2023 15:40
@scott-rc scott-rc merged commit d592ec1 into main Dec 15, 2023
7 checks passed
@scott-rc scott-rc deleted the sc/improve-edit-graphql branch December 15, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant