Use PQueue inside EditGraphQL subscriptions #1062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
PQueue
insideEditGraphQL
subscriptions so that we:This allows our GraphQL subscription handlers to be async while still ensuring they run in the expected order. This also helps us write tests where we can
await
the handler of a message rather than watching for external state to change.None of our current subscriptions need to process messages in parallel, in fact filesync already uses a
PQueue
internal to prevent this from happening. If we ever need to process messages in parallel in the future, we can add aconcurrency
option.