Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing resolved & integrity fields in npm-shrinkwrap.json #1068

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

kira-bruneau
Copy link
Contributor

Hey!! 👋

Was just updating my NUR repo and realized I should share a patch that makes it possible to build ggt with buildNpmPackage: https://gitlab.com/kira-bruneau/nur-packages/-/commit/1f044bbc14bb84acd51533dfadc8b63e7376c54d.

Apparently npm install doesn't include the integrity & resolved fields for packages that were already in the cache? npm/cli#4263.

I added those fields back with:

nix run github:jeslie0/npm-lockfile-fix ./npm-shrinkwrap.json && npm install

Copy link

changeset-bot bot commented Dec 16, 2023

⚠️ No Changeset found

Latest commit: 3fae04b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@scott-rc
Copy link
Collaborator

Hey Kira! Thanks for the PR!

Do I need to setup a script to do this every time we run npm install? Or is this a one time thing?

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Dec 18, 2023

I wouldn't worry about setting one up. It could happen again, but it's more just an edge case bug with npm.

It should only really happen if you add new packages with npm install, revert the changes to the generated lockfile and run npm install again.

@scott-rc
Copy link
Collaborator

I see. Okay, I'll merge this now and try to make sure this doesn't happen again 👍

Thanks!

@scott-rc scott-rc merged commit 4333013 into gadget-inc:main Dec 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants