Consolidate mocks

[scott-rc]

I've spent a lot of time debugging issues with mocked functions due to:

• mocking a function that's already been mocked and not knowing which implementation is being called
• typescript not realizing a function is already mocked and having to cast it

I discovered the vitest-mock-process package a while back and ended up using a helper function it exports called spyOnImplementing a lot. spyOnImplementing has a nicer api than vi.spyOn().mockImplementation() and it restores the function before mocking the implementation if it's already mocked.

This PR creates a new mock function that does everything spyOnImplementing does and more, and uses it everywhere we were mocking stuff in the past.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0edff2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[scott-rc]

I had to remove this because the new mock function, which is used a few times before each test, uses expect on its arguments making this assertion fail.