Added request error handling to notification flush #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airhorns
approved these changes
Jul 19, 2023
|
@pistachiobaby did you want to add the same error handling to the other places where we make HTTP requests to the IPC servers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our Internal GREAT FLAKE SHAKE we discovered that sometimes the wds child process will attempt to forward notifications to the parent when the parent is not active. This lead to sparse
EPIPEerrors being thrown.The underlying issue of the child forwarding requests to the parent exists, but this at least will avoid any crashing due to uncaught exceptions.