fix: prevent different typeof of components to be merged

theKashey · theKashey · commit 357249c42540 · 2019-07-04T19:11:32.000+10:00
diff --git a/src/reconciler/componentComparator.js b/src/reconciler/componentComparator.js
@@ -99,8 +99,8 @@ const areDeepSwappable = (oldType, newType) => {
 const compareComponents = (oldType, newType, setNewType, baseType) => {
   let defaultResult = oldType === newType;
 
-  if ((oldType && !newType) || (!oldType && newType)) {
-    return false;
+  if ((oldType && !newType) || (!oldType && newType) || typeof oldType !== typeof newType) {
+    return defaultResult;
   }
 
   if (getIdByType(oldType)) {

Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,8 @@ const areDeepSwappable = (oldType, newType) => {`
`99`	`99`	`const compareComponents = (oldType, newType, setNewType, baseType) => {`
`100`	`100`	`let defaultResult = oldType === newType;`
`101`	`101`
`102`		`- if ((oldType && !newType) \|\| (!oldType && newType)) {`
`103`		`- return false;`
	`102`	`+ if ((oldType && !newType) \|\| (!oldType && newType) \|\| typeof oldType !== typeof newType) {`
	`103`	`+ return defaultResult;`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`if (getIdByType(oldType)) {`