New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(regression) hook order change is causing React error #1394

Merged

theKashey merged 4 commits into master from hot-hook-fix

Nov 16, 2019

Collaborator

theKashey commented Nov 14, 2019

fixes #1393

update patch to remove current$$1.elementType === element.type condition, so our comparison would be used in all cases.
rollback fiber auto-update. Might reintroduce 4.12.13 breaks hot reloading in some cases #1342, not there is no choice (keep the elementType)

theKashey added 4 commits

November 14, 2019 23:35


          fix: (regression) hook order change is causing React error, fixes #1393

6707b4b


          fix: production babel plugin might perform eager replacement, fixes #…

b94adb3

…1388


          add tests for hook reload

300a819


          more rich test scenario fro hooks reload

29ef0a0

theKashey merged commit 35d329c into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet