Baseurl for xml #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like a typo, and I was hoping it would fix the problem, but it did not. The symptoms are simple: even when I use the `xinclude` option, the library still does not expand the <xi:include href='...'/> element, whereas xmllint does.
|
-> libxmljs#388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comprises two changes. I'll describe them as line comments below.
The main purpose of this PR is to add the
baseUrloption to FromXml. I noticed that this (and a few other options) were already added to FromHtml a long time ago, so I added them in the same way.I think the two methods should be refactored to move the common code (99% of it) to a common function. If it had been done that way originally, then users of FromXml would have benefited from these extra options added to FromHtml.