-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status action type #71
Comments
I've been thinking about this option. This will override the action on all the rules that have been defined. is that what you were thinking? meaning it will be at the workflow level, like dryRun. |
I think the best would be to add another enum to the |
dryRun
-> action: none
Re: discussion with @gagoar offline, perhaps the best way moving forward here is to introduce a new This new This also begs the question of whether we should introduce a |
**Issue Reference**: fixes #71 ## Description One good enhancement of failing a workflow is to just have rules that can fail or succeed on a commit status. this PR adds that feature. ## Motivation and Context We have found that failing the entire step when using `errorLevel: error` might be too blunt and perhaps we could a status as a way to display individual rules when `action` is set to `status` ## How Has This Been Tested? unit test and changing validation_template to use this feature moving forward.
in discussions about what the purpose of the
dryRun
flag is, it was a little confusing as to what it actually does.however, it is clear that
dryRun
true is the same asaction: none
, which i think is a little more clear in terms of "what happens when this rule passes"The text was updated successfully, but these errors were encountered: