Replace es6-map with a simple implementation of a map. #134
Conversation
| @@ -1,4 +1,4 @@ | |||
| import Map from 'es6-map'; | |||
| import Map from './simple-map'; | |||
There was a problem hiding this comment.
simple-map is very generic. What about calling it simple-weak-map?
There was a problem hiding this comment.
I'm not sure that is fitting, as keys are not weakly referenced like in a WeakMap. Your call though.
There was a problem hiding this comment.
It's not a weak map. Nor is a weak map required here.
There was a problem hiding this comment.
The reason I have suggested "weak map" is because keys are objects. @benjamingr Can you suggest a better name?
There was a problem hiding this comment.
Map, in regular ES2015 maps keys can be objects.
A WeakMap is a map that does not interfere with the garbage collection of its keys. If you'd like to see an example of why one would want to use it - see http://stackoverflow.com/questions/29413222/what-are-the-actual-uses-of-es6-weakmap . The "weakness" of the weak map is in that it holds the reference to the keys weakly.
There was a problem hiding this comment.
Thats useful. Thank you. Will keep it as simple-map then.
|
This should probably fall back to ES2015 maps if they are available. |
#133
Also, changed the
npm run pragmatistcommand so that it works on windows as well.