You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
QueryPointResultType is resulting it loads of errors throughout the codebase warning about attempts to cast an object into a string, e.g.
node_modules/mightyql/dist/types.js.flow:21
21: type QueryPointResultType = {|
^ object type. This type cannot be added to
78: const fuzzyAddressMatch = _.first(fuseUsingAddress.search(venueDetails.street + ', ' + venueDetails.postcode));
^^^^^^^^^^^^^^^^^^^^^^^^^^ string. See: src/bin/commands/update-venue-google-place-id.js:78
node_modules/mightyql/dist/types.js.flow:21
21: type QueryPointResultType = {|
^ object type. This type cannot be added to
78: const fuzzyAddressMatch = _.first(fuseUsingAddress.search(venueDetails.street + ', ' + venueDetails.postcode));
^^^^ string. See: src/bin/commands/update-venue-google-place-id.js:78
Found 3 errors
venueDetails is an instance of QueryResultRowType.
This is a valid error... technically venueDetails.street can be an object. Though guarding against every possible case as such is adding way too much boilerplate code.
The text was updated successfully, but these errors were encountered:
Considering how rare QueryPointResultType, I am inclined to remove this annotation at the moment, in favour of explicitly casting QueryResultRowType into QueryPointResultType-capable when required.
…ments containing references to positional paraameters
Earier, if you had a query such as sql`SELECT '$1'` Slonik would have thought that $1 is referring to a parameter that is expected to be bound to the query.
Slonik bindings produce custom placeholders (e.g. #$#1) that allow us to distinguish between values bound using Slonik and those added by the user.
QueryPointResultType
is resulting it loads of errors throughout the codebase warning about attempts to cast an object into a string, e.g.venueDetails
is an instance ofQueryResultRowType
.This is a valid error... technically
venueDetails.street
can be an object. Though guarding against every possible case as such is adding way too much boilerplate code.The text was updated successfully, but these errors were encountered: