replace i32 by u32 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good - could we add a test case? |
Closed
|
@gakonst Sorry I was off for some time and missed the notification :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacing
i32byu32in various places when interacting with the wasm. Quote from the wasmer docs:However, this can create overflows, for example right in
to_array32(I've introduced the bug in my other PR #14):0x100000000 - 1obviously doesn't fit ini32and let's theunwrap()fail.This is not visible in the current test cases, but happens as soon as you feed in large numbers as signals like hashes, we could also add a test case to catch this in the future.