fix(etherscan)!: change the GasOracle fields to be f64
#2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the `GasOracle`'s {safe_gase_price,propose_gas_price,fast_gas_price} from `u64` to `f64` to fix [BUG] Failed to deserialize etherscan response: data did not match any variant of untagged enum ResponseData #2324
BREAKING CHANGE: This considered a public api breaking change, since `f64` and `u64` is not compatible with each other.
mattsse
requested changes
Apr 5, 2023
This a required change after chaning the gas prices to be `f64`
|
Tested Locally with the repo in #2324 with my new updates and works correctly 🎉 ! INFO ethers_etherscan_issue: Gas Oracle Info, gas_oracle: Ok(GasOracle { safe_gas_price: 110.4, propose_gas_price: 127.4, fast_gas_price: 134.0, last_block: 41173362, suggested_base_fee: 80.380853619, gas_used_ratio: [0.447337990736135, 0.250362882144311, 0.414055028555671, 0.799576101506245, 0.419134294964152] })
at src/main.rs:39 |
prestwich
approved these changes
Apr 5, 2023
This was referenced Apr 5, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2324
Solution
This updates the
GasOracle's{safe_gase_price,propose_gas_price,fast_gas_price}fromu64tof64BREAKING CHANGE: This considered a public api breaking change, since
f64andu64is not compatible with each other.PR Checklist