feature: very permissive etherscan gwei deser #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekohex
suggested changes
Apr 5, 2023
Comment on lines
+33
to
+35
| // This function is used to deserialize a string or number into a U256 with an | ||
| // amount of gwei. If the contents is a number, deserialize it. If the contents | ||
| // is a string, attempt to deser as first a decimal f64 then a decimal U256. |
There was a problem hiding this comment.
Suggested change
| // This function is used to deserialize a string or number into a U256 with an | |
| // amount of gwei. If the contents is a number, deserialize it. If the contents | |
| // is a string, attempt to deser as first a decimal f64 then a decimal U256. | |
| // This function deserializes a string or number into a U256 with an amount of gwei. | |
| // If the content is a number, it is deserialized. If the content is a string, we attempt to deserialize it first // as a decimal f64 and then as a decimal U256. |
| use serde::{de, Deserialize, Deserializer}; | ||
| use std::{collections::HashMap, str::FromStr}; | ||
|
|
||
| const WEI_PER_GWEI: u64 = 1_000_000_000; |
There was a problem hiding this comment.
maybe use super::GWEI_TO_WEI instead?
Suggested change
| const WEI_PER_GWEI: u64 = 1_000_000_000; |
| } | ||
|
|
||
| match StringOrInt::deserialize(deserializer)? { | ||
| StringOrInt::Number(i) => Ok(U256::from(i) * WEI_PER_GWEI), |
There was a problem hiding this comment.
Suggested change
| StringOrInt::Number(i) => Ok(U256::from(i) * WEI_PER_GWEI), | |
| StringOrInt::Number(i) => Ok(U256::from(i) * super::GWEI_TO_WEI), |
There was a problem hiding this comment.
doesn't exist in this package, that's in the middleware, not in the etherscan
prestwich
force-pushed
the
prestwich/etherscan-gwei
branch
from
290a155
to
77d118c
Compare
shekohex
approved these changes
Apr 9, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely permissive deserializer for etherscan gas units
Motivation
More complete fix to #2326 #2325
Solution
Introduce a deser that performs the following in order:
change the etherscan response object to have
U256responses that are ALWAYS inweirather than in f64 gweiPR Checklist