Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Slerp method for quaternion is not normalized #508

Closed
yangfengzzz opened this issue Sep 14, 2021 · 0 comments · Fixed by #693
Closed

Static Slerp method for quaternion is not normalized #508

yangfengzzz opened this issue Sep 14, 2021 · 0 comments · Fixed by #693
Assignees
Labels
bug Something isn't working math Math library medium priority Medium priority issue
Milestone

Comments

@yangfengzzz
Copy link
Member

Describe the bug
the output of Slerp is not normalized, the output quaternion can't turn to be the transformation matrix.

The unit tests use non-normalized test data, so it is not found before.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@yangfengzzz yangfengzzz added the bug Something isn't working label Sep 14, 2021
@yangfengzzz yangfengzzz added this to the 0.6 milestone Sep 14, 2021
@GuoLei1990 GuoLei1990 modified the milestones: 0.6, 0.7 Nov 9, 2021
@GuoLei1990 GuoLei1990 added medium priority Medium priority issue math Math library labels Feb 7, 2022
@GuoLei1990 GuoLei1990 linked a pull request Mar 22, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working math Math library medium priority Medium priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants